raver119 wants to merge r119_ab_gpus into master October 27

[WIP] PW & Spark changes

Current Status: Analysed View logs
View on GitHub

Not up to standards. This pull request quality could be better.

+24
Issues
-1
Duplication
-16
Complexity
-
Coverage

deeplearning4j/deeplearning4j-core/src/test/java/org/deeplearning4j/datasets/iterator/DummyBlockDataSetIteratorTests.java

Method names should not contain underscores
37
public void testBlock_1() throws Exception {

deeplearning4j/deeplearning4j-data/deeplearning4j-utility-iterators/src/main/java/org/deeplearning4j/datasets/iterator/DummyBlockMultiDataSetIterator.java

Avoid unused imports such as 'org.nd4j.linalg.dataset.api.DataSet'
22
import org.nd4j.linalg.dataset.api.DataSet;
Avoid unused imports such as 'org.nd4j.linalg.dataset.api.iterator.BlockDataSetIterator'
24
import org.nd4j.linalg.dataset.api.iterator.BlockDataSetIterator;
Avoid unused imports such as 'org.nd4j.linalg.dataset.api.iterator.DataSetIterator'
26
import org.nd4j.linalg.dataset.api.iterator.DataSetIterator;

deeplearning4j/deeplearning4j-nn/src/main/java/org/deeplearning4j/optimize/solvers/accumulation/EncodedGradientsAccumulator.java

Avoid unused imports such as 'java.util.NoSuchElementException'
39
import java.util.NoSuchElementException;

deeplearning4j/deeplearning4j-nn/src/main/java/org/deeplearning4j/optimize/solvers/accumulation/IndexedTail.java

Avoid throwing raw exception types.
266
throw new RuntimeException("Element [" + e + "] is absent");

deeplearning4j/deeplearning4j-nn/src/test/java/org/deeplearning4j/optimize/solvers/accumulation/IndexedTailTest.java

Method names should not contain underscores
34
public void testDeltas_1() throws Exception {
Method names should not contain underscores
80
public void testMaxAppliedIndex_1() {
Method names should not contain underscores
115
public void testFirstNotApplied_1() {
Method names should not contain underscores
137
public void testSingleThreaded_1() throws Exception {
Method names should not contain underscores
159
public void testSingleThreaded_2() throws Exception {
Method names should not contain underscores
186
public void testSingleThreaded_3() throws Exception {
Method names should not contain underscores
208
public void testPseudoMultiThreaded_1() throws Exception {
Avoid modifying an outer loop incrementer in an inner loop for update expression
325
for (int e = 0; e < 1000; e++) {

deeplearning4j/deeplearning4j-nn/src/test/java/org/deeplearning4j/optimize/solvers/accumulation/SmartFancyBlockingQueueTest.java

Avoid using a branching statement as the last in a loop.
96
break;
Avoid unused local variables such as 'local'.
138
val local = arr.unsafeDuplication(true);
Avoid modifying an outer loop incrementer in an inner loop for update expression
168
for (int e = 0; e <250; e++) {
Avoid throwing raw exception types.
173
throw new RuntimeException(ex);
Avoid modifying an outer loop incrementer in an inner loop for update expression
218
for (int e = 0; e < 100; e++) {
Avoid throwing raw exception types.
241
throw new RuntimeException(e);
Avoid unused local variables such as 'fnt'.
303
int fnt = 0;

deeplearning4j/deeplearning4j-scaleout/deeplearning4j-scaleout-parallelwrapper/src/main/java/org/deeplearning4j/parallelism/ParallelWrapper.java

Avoid unused local variables such as 'nanos'.
519
val nanos = new ArrayList<Long>();

deeplearning4j/deeplearning4j-scaleout/spark/dl4j-spark-parameterserver/src/main/java/org/deeplearning4j/spark/parameterserver/pw/SharedTrainingWrapper.java

Avoid unused imports such as 'org.deeplearning4j.optimize.solvers.accumulation.SmartFancyBlockingQueue'
35
import org.deeplearning4j.optimize.solvers.accumulation.SmartFancyBlockingQueue;

nd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/dataset/api/iterator/BlockMultiDataSetIterator.java

Avoid unused imports such as 'org.nd4j.linalg.dataset.api.DataSet'
19
import org.nd4j.linalg.dataset.api.DataSet;

deeplearning4j/deeplearning4j-nn/src/main/java/org/deeplearning4j/optimize/solvers/accumulation/BasicGradientsAccumulator.java

Avoid unused imports such as 'java.util.Queue'
27
import java.util.Queue;
Avoid unused imports such as 'java.util.concurrent.LinkedTransferQueue'
31
import java.util.concurrent.LinkedTransferQueue;

deeplearning4j/deeplearning4j-nn/src/main/java/org/deeplearning4j/optimize/solvers/accumulation/EncodedGradientsAccumulator.java

Avoid unused imports such as 'org.nd4j.linalg.api.buffer.DataBuffer'
26
import org.nd4j.linalg.api.buffer.DataBuffer;
Avoid unused imports such as 'java.util.Queue'
40
import java.util.Queue;

deeplearning4j/deeplearning4j-nn/src/main/java/org/deeplearning4j/optimize/solvers/accumulation/GradientsAccumulator.java

Avoid unused imports such as 'java.util.Queue'
23
import java.util.Queue;

deeplearning4j/deeplearning4j-scaleout/deeplearning4j-scaleout-parallelwrapper/src/main/java/org/deeplearning4j/parallelism/ParallelWrapper.java

Avoid unused imports such as 'org.nd4j.linalg.dataset.api.DataSet'
46
import org.nd4j.linalg.dataset.api.DataSet;
Avoid unused imports such as 'org.nd4j.linalg.dataset.api.MultiDataSet'
47
import org.nd4j.linalg.dataset.api.MultiDataSet;

deeplearning4j/deeplearning4j-scaleout/spark/dl4j-spark-parameterserver/src/main/java/org/deeplearning4j/spark/parameterserver/networking/v1/SilentTrainingDriver.java

Avoid unused imports such as 'org.deeplearning4j.optimize.solvers.accumulation.FancyBlockingQueue'
23
import org.deeplearning4j.optimize.solvers.accumulation.FancyBlockingQueue;
Avoid unused imports such as 'java.util.concurrent.BlockingQueue'
38
import java.util.concurrent.BlockingQueue;
Avoid unused imports such as 'java.util.concurrent.LinkedBlockingQueue'
39
import java.util.concurrent.LinkedBlockingQueue;
Avoid empty if statements
124
if (reallyBypass) {

deeplearning4j/deeplearning4j-scaleout/spark/dl4j-spark-parameterserver/src/main/java/org/deeplearning4j/spark/parameterserver/networking/v2/UpdatesConsumer.java

Avoid unused imports such as 'org.deeplearning4j.optimize.solvers.accumulation.SmartFancyBlockingQueue'
29
import org.deeplearning4j.optimize.solvers.accumulation.SmartFancyBlockingQueue;
Avoid unused imports such as 'java.util.concurrent.BlockingQueue'
39
import java.util.concurrent.BlockingQueue;

deeplearning4j/deeplearning4j-scaleout/spark/dl4j-spark-parameterserver/src/main/java/org/deeplearning4j/spark/parameterserver/training/SharedTrainingMaster.java

Avoid unused imports such as 'org.datavec.spark.util.SerializableHadoopConfig'
30
import org.datavec.spark.util.SerializableHadoopConfig;

deeplearning4j/deeplearning4j-scaleout/spark/dl4j-spark/src/main/java/org/deeplearning4j/spark/impl/graph/SparkComputationGraph.java

Avoid unused imports such as 'org.apache.hadoop.conf.Configuration'
21
import org.apache.hadoop.conf.Configuration;

deeplearning4j/deeplearning4j-scaleout/spark/dl4j-spark/src/main/java/org/deeplearning4j/spark/impl/multilayer/SparkDl4jMultiLayer.java

Avoid unused local variables such as 'config'.
771
Configuration config = sc.hadoopConfiguration();

deeplearning4j/deeplearning4j-scaleout/spark/dl4j-spark/src/main/java/org/deeplearning4j/spark/impl/paramavg/ParameterAveragingTrainingMaster.java

Avoid unused imports such as 'org.datavec.spark.util.SerializableHadoopConfig'
31
import org.datavec.spark.util.SerializableHadoopConfig;

deeplearning4j/deeplearning4j-scaleout/deeplearning4j-scaleout-parallelwrapper/src/main/java/org/deeplearning4j/parallelism/ParallelWrapper.java

Avoid unused local variables such as 'nanos'.
536
List<Long> nanos = new ArrayList<>();

deeplearning4j/deeplearning4j-scaleout/spark/dl4j-spark/src/main/java/org/deeplearning4j/spark/impl/graph/evaluation/IEvaluateMDSPathsFlatMapFunction.java

Avoid unused imports such as 'org.deeplearning4j.eval.Evaluation'
30
import org.deeplearning4j.eval.Evaluation;
Avoid unused imports such as 'org.deeplearning4j.nn.conf.ComputationGraphConfiguration'
32
import org.deeplearning4j.nn.conf.ComputationGraphConfiguration;
Avoid unused imports such as 'org.deeplearning4j.nn.graph.ComputationGraph'
33
import org.deeplearning4j.nn.graph.ComputationGraph;
Avoid unused imports such as 'org.deeplearning4j.spark.iterator.SparkAMDSI'
36
import org.deeplearning4j.spark.iterator.SparkAMDSI;
Avoid unused imports such as 'org.nd4j.api.loader.SourceFactory'
37
import org.nd4j.api.loader.SourceFactory;
Avoid unused imports such as 'org.nd4j.linalg.api.ndarray.INDArray'
38
import org.nd4j.linalg.api.ndarray.INDArray;

deeplearning4j/deeplearning4j-nn/src/main/java/org/deeplearning4j/optimize/solvers/accumulation/EncodedGradientsAccumulator.java

The method applyUpdate() has an NPath complexity of 601
381
public void applyUpdate(StepFunction function, INDArray params, INDArray updates, double alpha) {

Loading..

Showing 14 files with hotspots

Loading...

Loading...

Loading...

Loading...