omniNotes/src/androidTest/java/it/feio/android/omninotes/utils/date/DateHelperTest.java
The field name indicates a constant but its modifiers do not
private int MILLISEC_TO_HOURS_RATIO = 60 * 60 * 1000;
omniNotes/src/main/java/it/feio/android/omninotes/BaseActivity.java
This final field could be made static
protected final int TRANSITION_HORIZONTAL = 1;
omniNotes/src/main/java/it/feio/android/omninotes/DetailFragment.java
A switch statement does not contain a break
switch (event.getAction()) {
Avoid using if statements without curly braces
if (swiping)
omniNotes/src/main/java/it/feio/android/omninotes/ListFragment.java
Avoid really long classes.
public class ListFragment extends BaseFragment implements OnViewTouchedListener, UndoBarController.UndoListener {
Avoid using if statements without curly braces
if (notesLoadedEvent.notes.size() == 0) list.setEmptyView(empyListItem);
omniNotes/src/main/java/it/feio/android/omninotes/MainActivity.java
This final field could be made static
public final String FRAGMENT_SKETCH_TAG = "fragment_sketch";
omniNotes/src/main/java/it/feio/android/omninotes/SettingsFragment.java
This final field could be made static
private final int SPRINGPAD_IMPORT = 0;
omniNotes/src/main/java/it/feio/android/omninotes/SketchFragment.java
Avoid using if...else statements without curly braces
AlphaManager.setAlpha(undo, 1f);
Avoid using if...else statements without curly braces
AlphaManager.setAlpha(redo, 1f);
omniNotes/src/main/java/it/feio/android/omninotes/async/CategoryMenuTask.java
Avoid using if statements without curly braces
if (settings == null) return categories;
omniNotes/src/main/java/it/feio/android/omninotes/async/MainMenuTask.java
Avoid using if statements without curly braces
if (dynamicMenu && dynamicNavigationLookupTable.getReminders() == 0)
Avoid using if statements without curly braces
if (dynamicMenu && dynamicNavigationLookupTable.getArchived() == 0)
Avoid using if statements without curly braces
if (dynamicMenu && dynamicNavigationLookupTable.getTrashed() == 0)
omniNotes/src/main/java/it/feio/android/omninotes/models/holders/NoteViewHolder.java
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.
@BindView(R.id.lockedIcon) public ImageView lockedIcon;
omniNotes/src/main/java/it/feio/android/omninotes/models/misc/DynamicNavigationLookupTable.java
Avoid using if statements without curly braces
else if (notes.get(i).getAlarm() != null) reminders++;
omniNotes/src/main/java/it/feio/android/omninotes/models/views/VerticalSeekBar.java
Avoid using if statements without curly braces
if (changeListener != null)
omniNotes/src/main/java/it/feio/android/omninotes/utils/StorageHelper.java
Avoid assignments in operands
while ((len = is.read(data)) > 0) {
Avoid using if statements without curly braces
if (!dir.exists())
omniNotes/src/main/java/it/feio/android/omninotes/widget/WidgetConfigurationActivity.java
A switch statement does not contain a break
switch (checkedId) {
More
Previous Next