GalRogozinski wants to merge spentaddresses-db January 9

Spent Addresses should be persisted in a seperate db instance

Current Status: Analysed View logs
View on GitHub

Not up to standards. This pull request quality could be better.

+20
Issues
=
Duplication
=
Complexity
-
Coverage

src/main/java/com/iota/iri/Iota.java

Avoid unused imports such as 'com.iota.iri.model.StateDiff'
7
import com.iota.iri.model.StateDiff;
Avoid unused imports such as 'com.iota.iri.model.persistables'
8
import com.iota.iri.model.persistables.*;
Avoid unused imports such as 'com.iota.iri.storage'
28
import com.iota.iri.storage.*;
Avoid unused imports such as 'java.util.HashMap'
34
import java.util.HashMap;
Avoid unused imports such as 'java.util.LinkedHashMap'
35
import java.util.LinkedHashMap;

src/main/java/com/iota/iri/storage/Tangle.java

Avoid unused imports such as 'com.iota.iri.model.persistables'
4
import com.iota.iri.model.persistables.*;
Avoid unused imports such as 'org.apache.commons.lang3.tuple.ImmutablePair'
11
import org.apache.commons.lang3.tuple.ImmutablePair;

src/main/java/com/iota/iri/storage/rocksDB/RocksDBPersistenceProvider.java

Public method and constructor comments are required
49
public RocksDBPersistenceProvider(String dbPath, String logPath, int cacheSize,
The method 'initDB(String, String, Map)' has a cyclomatic complexity of 11.
397
private void initDB(String path, String logPath, Map<String, Class<? extends Persistable>> columnFamilies) throws Exception {

src/test/java/com/iota/iri/benchmarks/dbbenchmark/states/DbState.java

Avoid unused imports such as 'com.iota.iri.Iota'
3
import com.iota.iri.Iota;

src/test/java/com/iota/iri/controllers/BundleViewModelTest.java

Avoid unused imports such as 'com.iota.iri.Iota'
3
import com.iota.iri.Iota;

src/test/java/com/iota/iri/controllers/MilestoneViewModelTest.java

Avoid unused imports such as 'com.iota.iri.Iota'
3
import com.iota.iri.Iota;

src/test/java/com/iota/iri/controllers/TransactionViewModelTest.java

Avoid unused imports such as 'com.iota.iri.Iota'
3
import com.iota.iri.Iota;

src/test/java/com/iota/iri/service/tipselection/impl/CumulativeWeightCalculatorTest.java

Avoid unused imports such as 'com.iota.iri.Iota'
4
import com.iota.iri.Iota;

src/test/java/com/iota/iri/service/tipselection/impl/RatingOneTest.java

Avoid unused imports such as 'com.iota.iri.Iota'
3
import com.iota.iri.Iota;

src/test/java/com/iota/iri/service/tipselection/impl/TailFinderImplTest.java

Avoid unused imports such as 'com.iota.iri.Iota'
3
import com.iota.iri.Iota;

src/test/java/com/iota/iri/service/tipselection/impl/WalkValidatorImplTest.java

Avoid unused imports such as 'com.iota.iri.Iota'
3
import com.iota.iri.Iota;

src/test/java/com/iota/iri/service/tipselection/impl/WalkerAlphaTest.java

Avoid unused imports such as 'com.iota.iri.Iota'
3
import com.iota.iri.Iota;

src/test/java/com/iota/iri/storage/TangleTest.java

Avoid unused imports such as 'com.iota.iri.Iota'
3
import com.iota.iri.Iota;

src/test/java/com/iota/iri/storage/rocksDB/RocksDBPersistenceProviderTest.java

Avoid unused imports such as 'com.iota.iri.Iota'
3
import com.iota.iri.Iota;

src/main/java/com/iota/iri/Iota.java

Unnecessary use of fully qualified name 'com.iota.iri.model.persistables.Address' due to existing import 'com.iota.iri.model.persistables.*'
227
tangle.clearColumn(com.iota.iri.model.persistables.Address.class);
Unnecessary use of fully qualified name 'com.iota.iri.model.persistables.Bundle' due to existing import 'com.iota.iri.model.persistables.*'
228
tangle.clearColumn(com.iota.iri.model.persistables.Bundle.class);
Unnecessary use of fully qualified name 'com.iota.iri.model.persistables.Approvee' due to existing import 'com.iota.iri.model.persistables.*'
229
tangle.clearColumn(com.iota.iri.model.persistables.Approvee.class);
Unnecessary use of fully qualified name 'com.iota.iri.model.persistables.ObsoleteTag' due to existing import 'com.iota.iri.model.persistables.*'
230
tangle.clearColumn(com.iota.iri.model.persistables.ObsoleteTag.class);
Unnecessary use of fully qualified name 'com.iota.iri.model.persistables.Tag' due to existing import 'com.iota.iri.model.persistables.*'
231
tangle.clearColumn(com.iota.iri.model.persistables.Tag.class);
Unnecessary use of fully qualified name 'com.iota.iri.model.persistables.Milestone' due to existing import 'com.iota.iri.model.persistables.*'
232
tangle.clearColumn(com.iota.iri.model.persistables.Milestone.class);
Unnecessary use of fully qualified name 'com.iota.iri.model.StateDiff' due to existing import 'com.iota.iri.model.StateDiff'
233
tangle.clearColumn(com.iota.iri.model.StateDiff.class);
Unnecessary use of fully qualified name 'com.iota.iri.model.persistables.Transaction' due to existing import 'com.iota.iri.model.persistables.*'
234
tangle.clearMetadata(com.iota.iri.model.persistables.Transaction.class);

src/main/java/com/iota/iri/service/snapshot/impl/SnapshotServiceImpl.java

Avoid unused private fields such as 'spentAddressesProvider'.
85
private SpentAddressesProvider spentAddressesProvider;

src/main/java/com/iota/iri/service/spentaddresses/impl/SpentAddressesProviderImpl.java

Avoid unused private fields such as 'log'.
32
private static final Logger log = LoggerFactory.getLogger(SpentAddressesProviderImpl.class);

src/main/java/com/iota/iri/storage/rocksDB/RocksDBPersistenceProvider.java

Avoid unused imports such as 'com.iota.iri.model.persistables'
5
import com.iota.iri.model.persistables.*;
Public method and constructor comments are required
73
public RocksDBPersistenceProvider(String dbPath, String logPath, int cacheSize) {

Loading...

Loading...

Loading...

Loading...